NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

EnumerableSet: Remove Boundary Check in _at (#2606)

Browse Source 
* remove boundary check

* fix tests for EnumerableSet "index out of bound"

* Changelog

Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
This commit is contained in:
William Morriss
2021-04-20 12:51:26 -07:00
committed by GitHub
parent 750a17653d
commit 165e6f1948
3 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -2,6 +2,7 @@
## Unreleased
* Enumerables: Improve gas cost of removal in `EnumerableSet` and `EnumerableMap`.
* Enumerables: Improve gas cost of lookup in `EnumerableSet` and `EnumerableMap`.
## Unreleased

1
contracts/utils/structs/EnumerableSet.sol
View File

@ -127,7 +127,6 @@ library EnumerableSet {
* - `index` must be strictly less than {length}.
*/
function _at(Set storage set, uint256 index) private view returns (bytes32) {
require(set._values.length > index, "EnumerableSet: index out of bounds");
return set._values[index];
}

2
test/utils/structs/EnumerableSet.behavior.js
View File

@ -51,7 +51,7 @@ function shouldBehaveLikeSet (valueA, valueB, valueC) {
describe('at', function () {
it('reverts when retrieving non-existent elements', async function () {
await expectRevert(this.set.at(0), 'EnumerableSet: index out of bounds');
await expectRevert.unspecified(this.set.at(0));
});
});