NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove duplicated SLOAD in Arrays.findUpperBound (#4442)

Browse Source 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Francisco Giordano <fg@frang.io>
This commit is contained in:
Molly
2023-07-12 16:07:35 -04:00
committed by GitHub
parent 921ac49ccb
commit 0abf18f305
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/fluffy-countries-buy.md Normal file
View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`Arrays`: Optimize `findUpperBound` by removing redundant SLOAD.

8
contracts/utils/Arrays.sol
View File

@ -22,13 +22,13 @@ library Arrays {
* repeated elements. * repeated elements.
*/ */
function findUpperBound(uint256[] storage array, uint256 element) internal view returns (uint256) { function findUpperBound(uint256[] storage array, uint256 element) internal view returns (uint256) {
if (array.length == 0) {
return 0;
}
uint256 low = 0; uint256 low = 0;
uint256 high = array.length; uint256 high = array.length;
if (high == 0) {
return 0;
}
while (low < high) { while (low < high) {
uint256 mid = Math.average(low, high); uint256 mid = Math.average(low, high);