NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add Slither reentrancy exception to GovernorTimelockAccess._queueOperations (#5643)

Browse Source 
Co-authored-by: Arr00 <13561405+arr00@users.noreply.github.com>
This commit is contained in:
Ernesto García
2025-04-21 12:02:30 -06:00
committed by GitHub
parent 21c8312b02
commit 06ea3b1b4e
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
contracts/governance/extensions/GovernorTimelockAccess.sol
View File

@ -237,6 +237,9 @@ abstract contract GovernorTimelockAccess is Governor {
for (uint256 i = 0; i < targets.length; ++i) { for (uint256 i = 0; i < targets.length; ++i) {
(, bool withDelay, ) = _getManagerData(plan, i); (, bool withDelay, ) = _getManagerData(plan, i);
if (withDelay) { if (withDelay) {
// This function can reenter when calling `_manager.schedule` before performing state updates in `_setManagerData`.
// However, the `manager` is a trusted contract in the current context's security model (e.g. an `AccessManager`).
// slither-disable-next-line reentrancy-no-eth
(, uint32 nonce) = _manager.schedule(targets[i], calldatas[i], etaSeconds); (, uint32 nonce) = _manager.schedule(targets[i], calldatas[i], etaSeconds);
_setManagerData(plan, i, true, nonce); _setManagerData(plan, i, true, nonce);
} }