Using extcodehash instead of extcodesize for less gas (#1802)
* Using extcodehash instead of extcodesize for less gas `extcodehash` uses less gas then `extcodesize`. You can tell which address is a contract by the hash (see EIP-1052). * Fix * Add explainer * Update Address.sol * add changelog entry
This commit is contained in:
committed by
Francisco Giordano
parent
c9f328ef66
commit
0282c3608d
@ -5,6 +5,11 @@
|
|||||||
### New features:
|
### New features:
|
||||||
* `Address.toPayable`: added a helper to convert between address types without having to resort to low-level casting. ([#1773](https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1773))
|
* `Address.toPayable`: added a helper to convert between address types without having to resort to low-level casting. ([#1773](https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1773))
|
||||||
|
|
||||||
|
### Improvements:
|
||||||
|
* `Address.isContract`: switched from `extcodesize` to `extcodehash` for less gas usage. ([#1802](https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1802))
|
||||||
|
|
||||||
|
### Bugfixes
|
||||||
|
|
||||||
## 2.3.0 (2019-05-27)
|
## 2.3.0 (2019-05-27)
|
||||||
|
|
||||||
### New features:
|
### New features:
|
||||||
|
|||||||
@ -19,10 +19,14 @@ library Address {
|
|||||||
// construction, since the code is only stored at the end of the
|
// construction, since the code is only stored at the end of the
|
||||||
// constructor execution.
|
// constructor execution.
|
||||||
|
|
||||||
uint256 size;
|
// According to EIP-1052, 0x0 is the value returned for not-yet created accounts
|
||||||
|
// and 0xc5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470 is returned
|
||||||
|
// for accounts without code, i.e. `keccak256('')`
|
||||||
|
bytes32 codehash;
|
||||||
|
bytes32 accountHash = 0xc5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470;
|
||||||
// solhint-disable-next-line no-inline-assembly
|
// solhint-disable-next-line no-inline-assembly
|
||||||
assembly { size := extcodesize(account) }
|
assembly { codehash := extcodehash(account) }
|
||||||
return size > 0;
|
return (codehash != 0x0 && codehash != accountHash);
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|||||||
Reference in New Issue
Block a user