NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Optimize Math.max and SignedMath.max (#3679)

Browse Source 
Co-authored-by: Daniel Liu <liudaniel@qq.com>
This commit is contained in:
Daniel Liu
2022-09-05 22:37:43 +08:00
committed by GitHub
parent 84fafa7832
commit 005a35b02a
3 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -29,6 +29,7 @@
* `Arrays`: Add `unsafeAccess` functions that allow reading and writing to an element in a storage array bypassing Solidity's "out-of-bounds" check. ([#3589](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3589)) * `Arrays`: Add `unsafeAccess` functions that allow reading and writing to an element in a storage array bypassing Solidity's "out-of-bounds" check. ([#3589](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3589))
* `Strings`: optimize `toString`. ([#3573](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3573)) * `Strings`: optimize `toString`. ([#3573](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3573))
* `Ownable2Step`: extension of `Ownable` that makes the ownership transfers a two step process. ([#3620](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3620)) * `Ownable2Step`: extension of `Ownable` that makes the ownership transfers a two step process. ([#3620](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3620))
* `Math` and `SignedMath`: optimize function `max` by using `>` instead of `>=`. ([#3679](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3679))
### Breaking changes ### Breaking changes

2
contracts/utils/math/Math.sol
View File

@ -17,7 +17,7 @@ library Math {
* @dev Returns the largest of two numbers. * @dev Returns the largest of two numbers.
*/ */
function max(uint256 a, uint256 b) internal pure returns (uint256) { function max(uint256 a, uint256 b) internal pure returns (uint256) {
return a >= b ? a : b; return a > b ? a : b;
} }
/** /**

2
contracts/utils/math/SignedMath.sol
View File

@ -11,7 +11,7 @@ library SignedMath {
* @dev Returns the largest of two signed numbers. * @dev Returns the largest of two signed numbers.
*/ */
function max(int256 a, int256 b) internal pure returns (int256) { function max(int256 a, int256 b) internal pure returns (int256) {
return a >= b ? a : b; return a > b ? a : b;
} }
/** /**